Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#493 - rustfmt ignore deprecated #495

Closed
wants to merge 1 commit into from
Closed

#493 - rustfmt ignore deprecated #495

wants to merge 1 commit into from

Conversation

Elrendio
Copy link
Contributor

@Elrendio Elrendio commented Jun 7, 2020

Resolves #493

What it does:

  • Replaces deprecated #![cfg_attr(rustfmt, rustfmt_skip)] with #![rustfmt::skip]

**What it does:**
 - Replaces deprecated `#![cfg_attr(rustfmt, rustfmt_skip)]` with `#![rustfmt::skip]`
@Elrendio
Copy link
Contributor Author

Elrendio commented Jun 7, 2020

I've noticed many use of #![cfg_attr(rustfmt, rustfmt_skip)] in the code do you want me to replace them also ?

@Elrendio
Copy link
Contributor Author

Elrendio commented Jun 7, 2020

I'm getting quite a lot of unused warnings for #![rustfmt::skip] which is kinda expected. They should disappear with rust 1.44.1 but the failing tests seem unrelated 🤔

@stepancheg
Copy link
Owner

Something was broken (or changed) in Rust which caused tests failure: rust-lang/rust#73573

@stepancheg
Copy link
Owner

I modified your PR to also include:

#![allow(unused_attributes)]

in generated code. Pushed as 7012c8c. Is that right?

@Elrendio
Copy link
Contributor Author

@stepancheg Alright for me 🙂 Seems that you've pushed the fix directly on master, therefore closing this PR.

@Elrendio Elrendio closed this Jun 22, 2020
@Elrendio Elrendio deleted the #493-RustfmtIgnoreDeprecated branch June 22, 2020 19:06
@hds hds mentioned this pull request Jun 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

rustfmt ignore deprecated
2 participants